-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(astro): Fixes prerender conflicts of lower-priority routes #11694
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 23767b5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Whoops, I didn't consider the fallback routes. Back to the board |
Fallback routes should be really simple to handle. However, maybe we should refactor them. At the moment they contain copies of what we already have inside |
@Fryuni any updates? |
Changes
Testing
A new lower-priority route (with a rest parameter) was added to the
ssr-prerender
test suite that conflicts with the pre-rendered/static
route and the SSR/not-prerendered
route. The new route must be skipped in both cases, resulting in:/static
path with the contents of the/static
route/not-prerendered
being prerenderedDocs
The new behavior matches what is already documented.